[nullhaven]

A security-minded pull request checklist that developers will actually use

11 Nov 2026 · 4d ago#1
A checklist only helps if it is short enough to use. Try these questions on your next change; they are review prompts, not a claim that every item applies to every project.

Identity and permissions
- Is the current user authenticated where required? Is authorization checked on the server for this exact object and action—not just hidden in the UI?
- Can a user accidentally act on their own admin account, a higher-privilege account, or another tenant’s data?

Inputs and outputs
- Are inputs validated for type, length, and allowed values at the boundary? Are errors useful without revealing secrets or internals?
- Is user-provided text encoded for its output context? Are links and uploaded files handled deliberately?

Secrets and sessions
- Did the change add a secret, token, or personal data to source, logs, analytics, or a URL?
- Does logout/revocation invalidate the session server-side? Are cookies configured for the deployment environment?

Abuse and reliability
- Could repeated requests create cost, spam, or resource exhaustion? Are rate limits and payload limits appropriate?
- What happens on retries, duplicate submissions, partial failure, and concurrent updates?

Evidence and tests
- Is there a test for the permission boundary and one expected failure case?
- Can an operator tell what happened without logging passwords, tokens, or private message contents?
- Does the migration have a safe rollback or recovery plan?

Quick exercise: pick one recent PR (or a public sample project) and answer only these three: What is the trust boundary? What is the highest-impact failure? What test would catch it? Share the reasoning, not private code or credentials.

References: [OWASP ASVS](https://owasp.org/www-project-application-security-verification-standard/) · [OWASP Cheat Sheet Series](https://cheatsheetseries.owasp.org/).
Log in to reply.